[UI v2] feat: Updates combobox filtering logic for automations#16737
Merged
devinvillarosa merged 1 commit intomainfrom Jan 16, 2025
Merged
[UI v2] feat: Updates combobox filtering logic for automations#16737devinvillarosa merged 1 commit intomainfrom
devinvillarosa merged 1 commit intomainfrom
Conversation
devinvillarosa
force-pushed
the
filter-automation-list
branch
from
661ebc0 to
a061375
Compare
devinvillarosa
requested review from
aaazzam,
cicdw,
desertaxle and
zzstoatzz
as code owners
devinvillarosa
force-pushed
the
filter-automation-list
branch
from
a061375 to
65bb8cd
Compare
devinvillarosa
commented
Jan 16, 2025
Contributor
Author
There was a problem hiding this comment.
Moved to .ts to resolve jsx re-rendering warning
devinvillarosa
force-pushed
the
filter-automation-list
branch
from
65bb8cd to
4d67990
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates combobox to have developers to use our own filtering mechanism. When trying to integrate it with other data resources, it doesn't seem like we'll be using
cmdk's built in filtering mechanicsUpdates
AutomationsSelectStateFieldscomponent to use our own filtering mechanism. Because there is no API support for filtering by_likename, opting to do filtering on the client sideScreen.Recording.2025-01-15.at.12.37.52.PM.mov
Checklist
<link to issue>"mint.json.Relates to #15512